Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PropsDB overrides #62

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add PropsDB overrides #62

merged 1 commit into from
Sep 19, 2024

Conversation

oschulz
Copy link
Contributor

@oschulz oschulz commented Sep 8, 2024

Override data locations are

/path/to/metadata/jldataprod/overrides/metadata/...
/path/to/metadata/jldataprod/overrides/par/...
/path/to/metadata/jldataprod/overrides/jlpar/...

@theHenks can you test if this PR works for you?

@oschulz oschulz requested a review from theHenks September 8, 2024 23:40
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 52.52525% with 47 lines in your changes missing coverage. Please review.

Project coverage is 33.25%. Comparing base (469a00e) to head (d9483fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/props_db.jl 50.54% 45 Missing ⚠️
src/legend_data.jl 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   33.00%   33.25%   +0.25%     
==========================================
  Files          27       27              
  Lines        1618     1690      +72     
==========================================
+ Hits          534      562      +28     
- Misses       1084     1128      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theHenks theHenks linked an issue Sep 17, 2024 that may be closed by this pull request
@oschulz
Copy link
Contributor Author

oschulz commented Sep 19, 2024

I'll merge this, we can always improved it some more later.

@oschulz oschulz merged commit d9483fa into main Sep 19, 2024
7 checks passed
@oschulz oschulz deleted the propsdb-overrides branch September 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwrite Functionality for dataprod config
1 participant