Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NoSuchPropsDBEntry #14

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add NoSuchPropsDBEntry #14

merged 1 commit into from
Oct 17, 2023

Conversation

oschulz
Copy link
Contributor

@oschulz oschulz commented Oct 16, 2023

Enables

julia> pd.no.such.props.yet isa LegendDataManagement.NoSuchPropsDBEntry
true

julia> writeprops(pd.no.such.props.yet, PropDict("foo" => 42))


julia> pd.no.such.props.yet isa PropDict
true

@oschulz
Copy link
Contributor Author

oschulz commented Oct 16, 2023

CC @theHenks

@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/props_db.jl 56.60% <8.69%> (-6.78%) ⬇️

📢 Thoughts on this report? Let us know!.

@oschulz oschulz merged commit 63d02ca into main Oct 17, 2023
7 of 10 checks passed
@oschulz oschulz deleted the gen-propdb-files branch October 17, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oschulz