refactor(components): unified user name positions to [surname, ]<name>

Ticket: issue/Transversal-196 Reviewed-by: @MIGUELez11 Refs: #158
leemonade · May 24, 2024 · b9bf541 · b9bf541
1 parent f8c4f91
commit b9bf541
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/components/src/helpers/getUserFullName.js b/packages/components/src/helpers/getUserFullName.js
@@ -1,9 +1,7 @@
 function getUserFullName(user) {
-  return (
-    (user.name ? user.name : '') +
-    (user.surnames ? ` ${user.surnames}` : '') +
-    (user.secondSurname ? ` ${user.secondSurname}` : '')
-  );
+  return `${user.secondSurname ? `${user.secondSurname} ` : ''}${
+    user.surnames ? user.surnames : ''
+  }${user.secondSurname || user.surnames ? ', ' : ''}${user.name}`;
 }
 
 export { getUserFullName };
diff --git a/packages/components/src/informative/UserDisplayItem/UserDisplayItem.js b/packages/components/src/informative/UserDisplayItem/UserDisplayItem.js
@@ -84,7 +84,10 @@ const UserDisplayItem = (properties) => {
 
   const role = useMemo(() => (!isEmpty(center) ? `${rol} · ${center}` : rol), [rol, center]);
   const fullName = useMemo(
-    () => (['rol', 'inline'].includes(variant) ? `${surnames || ''} ${name}` : name),
+    () =>
+      ['rol', 'inline'].includes(variant)
+        ? `${surnames || ''}${!surnames ? '' : ', '}${name}`
+        : name,
     [name, surnames, variant],
   );