Feat(sbtc): display sbtc balance market data #5991
Open
+879
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
feat/display-sbtc
branch
5 times, most recently
from
e1fff05
to
949532f
Compare
kyranjamie
force-pushed
the
feat/display-sbtc
branch
from
949532f
to
9a6fd5f
Compare
kyranjamie
force-pushed
the
feat/display-sbtc
branch
4 times, most recently
from
cf5e2f4
to
ac141e6
Compare
kyranjamie
force-pushed
the
feat/display-sbtc
branch
from
ac141e6
to
190d197
Compare
fbwoolf
reviewed
Nov 30, 2024
| @@ -181,7 +181,7 @@ | |||
| "@stacks/profile": "6.15.0", | |||
| "@stacks/rpc-client": "1.0.3", | |||
| "@stacks/storage": "6.15.0", | |||
| "@stacks/transactions": "6.17.0", | |||
| "@stacks/transactions": "7.0.2", | |||
There was a problem hiding this comment.
I am hitting a lot of errors with @stacks/transactions imports with this change, what am I missing?
There was a problem hiding this comment.
All good if I revert it back...
There was a problem hiding this comment.
I see we prob need lib update for the sbtc tx. Still looking thru this so ignore me, haha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures sBTC displays correctly, with market data.
There are several design variants I'm not entirely sure which we should go for. No icon for now because apparently there's a new one on the way.
I'm a bit uncertain how we should handle sBTC specific behaviour. Either we can treat is separately from other SIP-10s or, manipulate the data/events we pass to the SIP-10 components such that it displays/behaves as we expect. Trying to avoid lots of
if (symbol === 'sBTC')-like code.