fix: virtuoso list fixed height #5988
Merged
+132
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
approved these changes
Nov 25, 2024
Comment on lines
17
to
19
| const onResize = () => { | ||
| setKey(Date.now()); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const onResize = () => { | |
| setKey(Date.now()); | |
| }; | |
| function onResize() { | |
| setKey(Date.now()); | |
| } |
nit, but can you also explain why we need to update the key on resize? This seems like a bit of a hack? 🤔
Could useId be used here instead?
There was a problem hiding this comment.
I believe this is done for re-render virtual list on resize
I tested without this and worked ok, prob was done for removed logic work ok
so, removed this
alter-eggo
force-pushed
the
fix/switch-mb2
branch
from
f1d2dc8
to
32007d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes problems of fixed virtual scroller wrapper height, when we needed to calc it's height depending on header height
blocked by: leather-io/mono#649