-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): background analytics event #5675
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
6734b04
to
34213a7
Compare
34213a7
to
9fa65a8
Compare
A longstanding issue we've faced with analytics is that both Mixpanel and Segment have open issues with their packages preventing support for Service Workers. This stops us from firing analytics from the background script associated with the same user as the app script.
This is especially relevant if we want to collect analytics on failed, or non-complaint, inbound RPC requests to Leather.
This PR presents a possible solution, where the background script queues analytics events in
chrome.storage.local
, and on initial load of a web frame, we read this store, track the queued events, and clear the queue.This should give us all the practical info we need, albeit with incorrect time stamps. Didn't want to get too distracted from key gen work, but figured I'd push something up while the idea was fresh.