Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(step-02) Add missing ViewerQueries headstart code #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomastuts
Copy link

@thomastuts thomastuts commented Nov 6, 2016

The docs mention the following in the 'Exercise 2' section:

To give you a headstart, we already defined ViewerQueries in index.js.

However, this bit of code is not in the step-02 branch. This PR fixes that!

@thomastuts thomastuts changed the title Add missing ViewerQueries headstart code (step-02) Add missing ViewerQueries headstart code Nov 6, 2016
@marktani
Copy link
Member

marktani commented Nov 7, 2016

hm I think we had an almost identical PR some time ago. Will further investigate!

@marktani
Copy link
Member

marktani commented Nov 7, 2016

See #12

The thing is that we either have a esllint error or a missing line of code 😛
Do you mind to instead change the text itself over at https://github.com/learnrelay/learnrelay/blob/master/content/queries/containers-fragments.md#composing-queries-using-fragments and https://github.com/learnrelay/learnrelay/blob/master/content/queries/containers-fragments.md#exercise-02-prepare-the-listpage-for-further-action to instruct the user to copy the line of code in the exercise themselves?

Copy link
Member

@marktani marktani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to have a look at the ViewerQueries issues and come up with a consistend solution

@marktani marktani self-assigned this Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants