Completed Practice DOM/Fetch Challenges #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
May 22, 2024
Comment on lines
+39
to
+57
| function sortBreeds() { | ||
| let select = document.getElementById('breed-dropdown') | ||
| select.addEventListener('change', () => { | ||
| dogList.innerText = '' | ||
| let letter = select.value | ||
|
|
||
| for(const dogBreed in dogObj) { | ||
| if(dogBreed[0] === letter) { | ||
| let li = document.createElement('li') | ||
| li.innerText = dogBreed | ||
| dogList.appendChild(li) | ||
| li.addEventListener('click', () => { | ||
| li.style.color = 'green' | ||
| }) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } sortBreeds() |
There was a problem hiding this comment.
This is definitely a cool way of doing this, but to make it more readable you could make the dogObj globally available and extract this function. That would make the code more readable and easier to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Practiced accessing information from the dog API and using it to update the DOM. Also practiced listening for user events and updating the DOM in response.