Complete Lab #26
Open
Complete Lab #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1,38 @@ | |||
| // Code your solution in this file! | |||
| function distanceFromHqInBlocks(num1){ | |||
There was a problem hiding this comment.
What do you think a better name for the argument num1 could be?
There was a problem hiding this comment.
Either would be good! I like blockNumber or even startingBlockNumber since it's most descriptive.
|
|
||
| function distanceFromHqInFeet(num) { | ||
| let feet = distanceFromHqInBlocks(num); | ||
| return feet * 264; |
There was a problem hiding this comment.
Suggested change
| return feet * 264; | |
| return feet * 264; |
Comment on lines
+16
to
+21
| let block; | ||
| if (start > destination) { | ||
| block = start - destination; | ||
| } else { | ||
| block = destination - start; | ||
| } return block * 264; |
There was a problem hiding this comment.
Since you're not doing anything with the block, you don't need to assign it to a constant.
Suggested change
| let block; | |
| if (start > destination) { | |
| block = start - destination; | |
| } else { | |
| block = destination - start; | |
| } return block * 264; | |
| if (start > destination) { | |
| return start - destination; | |
| } else { | |
| return destination - start; | |
| } |
| return 0; | ||
| } else if (distanceAfterFreeRide < 1600) { | ||
| return distanceAfterFreeRide * 0.02; | ||
| } else if (distanceAfterFreeRide >= 1600 && distanceAfterFreeRide <= 2100) { |
There was a problem hiding this comment.
Suggested change
| } else if (distanceAfterFreeRide >= 1600 && distanceAfterFreeRide <= 2100) { | |
| } else if (distanceAfterFreeRide <= 2100) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.