Passed all tests #22
Open
Passed all tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
Comment on lines
12
to
17
| if(destination > 42){ | ||
| return (destination - 42) * 264 | ||
| } | ||
| else{ | ||
| return (42 - destination) * 264 | ||
| } |
There was a problem hiding this comment.
Instead of duplicating the logic here, you can levage the the distanceFromHqInBlocks function:
Suggested change
| if(destination > 42){ | |
| return (destination - 42) * 264 | |
| } | |
| else{ | |
| return (42 - destination) * 264 | |
| } | |
| distanceFromHqInBlocks(destination) * 264 |
index.js
Outdated
Comment on lines
30
to
39
| const distance = start > destination ? (start - destination) * 264 : (destination - start) * 264 | ||
| if(distance <= 400 ){ | ||
| return 0; | ||
| }else if(distance > 400 && distance < 2000){ | ||
| return .02 * (distance-400); | ||
| }else if(distance > 2500){ | ||
| return 'cannot travel that far' | ||
| }else if(distance > 2000){ | ||
| return 25; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const distance = start > destination ? (start - destination) * 264 : (destination - start) * 264 | |
| if(distance <= 400 ){ | |
| return 0; | |
| }else if(distance > 400 && distance < 2000){ | |
| return .02 * (distance-400); | |
| }else if(distance > 2500){ | |
| return 'cannot travel that far' | |
| }else if(distance > 2000){ | |
| return 25; | |
| } | |
| const distance = start > destination ? (start - destination) * 264 : (destination - start) * 264 | |
| if(distance <= 400 ){ | |
| return 0; | |
| }else if(distance < 2000){ | |
| return .02 * (distance - 400); | |
| }else if(distance > 2500){ | |
| return 'cannot travel that far' | |
| }else if(distance > 2000){ | |
| return 25; | |
| } |
|
Cleaned up all functions and if blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.