Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: clear some porting notes on rfl #8063

Closed
wants to merge 4 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Oct 31, 2023

We remove some porting notes for rfls that by now work again.


Open in Gitpod

We remove some porting notes for `rfl`s that by now work again.
@mo271 mo271 added the WIP Work in progress label Oct 31, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Oct 31, 2023

It seems like two cases where a proof was broken during the port, and it was suspected that leanprover-community/batteries#62 was the reason now work again. So it seems the underlying cause of breakage might have been something else.

@mo271 mo271 added awaiting-review awaiting-CI and removed WIP Work in progress labels Oct 31, 2023
@eric-wieser
Copy link
Member

!bench

@eric-wieser
Copy link
Member

bors d+

I've seen cases where a convert proof for decidability instance is incredibly slow.

Copy link

bors bot commented Nov 1, 2023

✌️ mo271 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit aead19d.
There were no significant changes against commit f8593ac.

@mo271
Copy link
Collaborator Author

mo271 commented Nov 1, 2023

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2023
We remove some porting notes for `rfl`s that by now work again.




Co-authored-by: Moritz Firsching <[email protected]>
Copy link

bors bot commented Nov 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: clear some porting notes on rfl [Merged by Bors] - chore: clear some porting notes on rfl Nov 1, 2023
@bors bors bot closed this Nov 1, 2023
@bors bors bot deleted the mo271/rfl_porting_notes branch November 1, 2023 09:55
fgdorais pushed a commit that referenced this pull request Nov 1, 2023
We remove some porting notes for `rfl`s that by now work again.




Co-authored-by: Moritz Firsching <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants