Unify namespace #208
Merged
Unify namespace #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typed properties need PHP 7.4, and after read the documentation the minimal PHP version is 7.2 (because in If you want I can't remove the Typed properties. |
|
Hey @joanhey I'm aware of the PHP 7.4 EOL. Leaf still supports PHP 7 just to help people with easy adoption/migration of older systems since a Leaf app in PHP 7 will be exactly the same in PHP 8. Also, I've updated the minimum requirement for the next version from 7.2 to 7.4, so this is perfectly fine |
mychidarko
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the App Class, use namespace Leaf, any function or class call will be relative to that namespace.
Actually exist a mix of fully qualified namespaces and normal.
Now all use normal qualified.
Also added type hint to the properties.