Unify platforms #10
Open
Unify platforms #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other than shaving of a whopping 4 bytes from the binary, this is just the most straight-forward way of resetting bits. Signed-off-by: Tormod Volden <[email protected]>
common.h itself is the only file to include config.h Signed-off-by: Tormod Volden <[email protected]>
Signed-off-by: Tormod Volden <[email protected]>
|
Awesome! The diffs look good. I'm out of town at the moment, but will try it out early next week. |
|
OK. Meanwhile I will split out "Also remove spurious configuration of the whole LED (GPIOA) bank" as a separate commit - this is a real and significant change, while the rest is just refactored code. |
|
The above GPIOA bank initialization change is not significant as long as SetupLED() is the first to configure that bank, but I split it out anyway. |
This is not much of an issue as long as SetupLED() is the first place the GPIOA bank is configured and the ports are inputs anyway, but it would cause trouble if something tried to configure any of the ports before SetupLED(). Note that ports are by default floating inputs after reset, but this configuration was setting them to analog inputs instead. Signed-off-by: Tormod Volden <[email protected]>
Signed-off-by: Tormod Volden <[email protected]>
Example: make PLATFORM=MAPLE Signed-off-by: Tormod Volden <[email protected]>
Example: make PLATFORM=MAPLE_MINI Signed-off-by: Tormod Volden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can maintain Maple and Maple Mini (and others) in the same branch. I have tested it on Maple Mini. Remember to run "make clean" when switching platforms.