-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for newer Sapphire Plus rev. with dual Endstopps | E3D Hemera preconfig for Sapphire Plus #33
Open
RolfZuckowskiUltras
wants to merge
14
commits into
le3tspeak:MKS-Robin-Nano
Choose a base branch
from
RolfZuckowskiUltras:MKS-Robin-Nano
base: MKS-Robin-Nano
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Adding compability for newer Sapphire-Plus revisions with non-belt-synced Z-Axis with dual endstopps -Adding out of the box compability for E3D Hemera with the Sapphire Plus (Hemera not tested with Sapphire Pro yet!) Tested with Sapphire Plus Hemera Extruder direction has to be maybe diverted with factory BMG clone.
Corrected Hemera PID-Values since I don't wanna spam Pull-Requests: p:14.67 i:1.62 d:33.22 |
Improved PID-Values
Compiled Bins for -Sapphire Plus Dual Z -Sapphire Plus Dual Z with Hemera -Sapphire Pro with Hemera
Works fine on my sapphire plus with dual Z. It can be merged |
Gleeno
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would confirm that this preconfig file works very well on Two Trees Sapphire Plus with dual Z stepper/endstop.
Thank you
Updated Borders and optimized Jerk/Acceleration parameters for E3D Hemera
Forgot to delete uncomment in conf_adv after update of the fork.
…s, when hemera is used. X-Bed Size now: 0mm..288mm Y-Bed Size now 0mm..296mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your nice work with the pre-compile directives for the configuration of the machines. Helped me a lot.
New Sapphire Plus revision
Newer revisions (manufactures after around April 2020 / Mine is from May) of the Sapphire Plus were improved by adding non-belt-synced Z-Drives with dual endstopps.
Added features:
** - Dual Z-Drive support**
(Building up on the "normal" Sapphire Plus)
** - Hemera Support**
Modified:
Issues:
No known Issues.
Edit: Issue was (as mentioned) Slicer-Caused. The Hemera is just too fast for the default minimum layer time...