Skip to content

Commit

Permalink
riscv: Rename SiFive CLINT to RISC-V ALINT
Browse files Browse the repository at this point in the history
As the RISC-V ACLINT specification is defined to be backward compatible
with the SiFive CLINT specification, we rename SiFive CLINT to RISC-V
ALINT in the source tree to be future-proof.

Signed-off-by: Bin Meng <[email protected]>

Series-to: [email protected]
Cover-letter:
riscv: Add ACLINT mtimer and mswi devices support

This RISC-V ACLINT specification [1] defines a set of memory mapped
devices which provide inter-processor interrupts (IPI) and timer
functionalities for each HART on a multi-HART RISC-V platform.

This seriesl updates U-Boot existing SiFive CLINT driver to handle
the ACLINT changes, and is now able to support both CLINT and ACLINT.

With this series, U-Boot is able to boot on:

- QEMU 'virt' machine with 'aclint=on'
- Rocket Chip with ACLINT changes [2]

[1] https://github.com/riscv/riscv-aclint/blob/main/riscv-aclint.adoc
[2] chipsalliance/rocket-chip#3330
END
  • Loading branch information
lbmeng committed Jun 12, 2023
1 parent 1cd8931 commit 2476058
Show file tree
Hide file tree
Showing 14 changed files with 35 additions and 35 deletions.
2 changes: 1 addition & 1 deletion MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@ F: doc/arch/riscv.rst
F: doc/usage/sbi.rst
F: drivers/sysreset/sysreset_sbi.c
F: drivers/timer/andes_plmt_timer.c
F: drivers/timer/sifive_clint_timer.c
F: drivers/timer/riscv_aclint_timer.c
F: tools/prelink-riscv.c

RISC-V CANAAN KENDRYTE K210
Expand Down
8 changes: 4 additions & 4 deletions arch/riscv/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -185,22 +185,22 @@ config DMA_ADDR_T_64BIT
bool
default y if 64BIT

config SIFIVE_CLINT
config RISCV_ACLINT
bool
depends on RISCV_MMODE
select REGMAP
select SYSCON
help
The SiFive CLINT block holds memory-mapped control and status registers
The RISC-V ACLINT block holds memory-mapped control and status registers
associated with software and timer interrupts.

config SPL_SIFIVE_CLINT
config SPL_RISCV_ACLINT
bool
depends on SPL_RISCV_MMODE
select SPL_REGMAP
select SPL_SYSCON
help
The SiFive CLINT block holds memory-mapped control and status registers
The RISC-V ACLINT block holds memory-mapped control and status registers
associated with software and timer interrupts.

config SIFIVE_CACHE
Expand Down
2 changes: 1 addition & 1 deletion arch/riscv/cpu/fu540/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ config SIFIVE_FU540
imply CPU
imply CPU_RISCV
imply RISCV_TIMER if (RISCV_SMODE || SPL_RISCV_SMODE)
imply SPL_SIFIVE_CLINT
imply SPL_RISCV_ACLINT
imply CMD_CPU
imply SPL_CPU
imply SPL_OPENSBI
Expand Down
2 changes: 1 addition & 1 deletion arch/riscv/cpu/fu740/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ config SIFIVE_FU740
imply CPU
imply CPU_RISCV
imply RISCV_TIMER if (RISCV_SMODE || SPL_RISCV_SMODE)
imply SPL_SIFIVE_CLINT
imply SPL_RISCV_ACLINT
imply CMD_CPU
imply SPL_CPU
imply SPL_OPENSBI
Expand Down
4 changes: 2 additions & 2 deletions arch/riscv/cpu/generic/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ config GENERIC_RISCV
imply CPU
imply CPU_RISCV
imply RISCV_TIMER if (RISCV_SMODE || SPL_RISCV_SMODE)
imply SIFIVE_CLINT if RISCV_MMODE
imply SPL_SIFIVE_CLINT if SPL_RISCV_MMODE
imply RISCV_ACLINT if RISCV_MMODE
imply SPL_RISCV_ACLINT if SPL_RISCV_MMODE
imply CMD_CPU
imply SPL_CPU
imply SPL_OPENSBI
Expand Down
2 changes: 1 addition & 1 deletion arch/riscv/cpu/jh7110/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ config STARFIVE_JH7110
imply SPL_CPU
imply SPL_LOAD_FIT
imply SPL_OPENSBI
imply SPL_SIFIVE_CLINT
imply SPL_RISCV_ACLINT
4 changes: 2 additions & 2 deletions arch/riscv/include/asm/global_data.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
struct arch_global_data {
long boot_hart; /* boot hart id */
phys_addr_t firmware_fdt_addr;
#if CONFIG_IS_ENABLED(SIFIVE_CLINT)
void __iomem *clint; /* clint base address */
#if CONFIG_IS_ENABLED(RISCV_ACLINT)
void __iomem *aclint; /* aclint base address */
#endif
#ifdef CONFIG_ANDES_PLICSW
void __iomem *plicsw; /* andes plicsw base address */
Expand Down
2 changes: 1 addition & 1 deletion arch/riscv/include/asm/syscon.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*/
enum {
RISCV_NONE,
RISCV_SYSCON_CLINT, /* Core Local Interruptor (CLINT) */
RISCV_SYSCON_ACLINT, /* Advanced Core Local Interruptor (ACLINT) */
RISCV_SYSCON_PLICSW, /* Andes PLICSW */
};

Expand Down
2 changes: 1 addition & 1 deletion arch/riscv/lib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ obj-$(CONFIG_CMD_GO) += boot.o
obj-y += cache.o
obj-$(CONFIG_SIFIVE_CACHE) += sifive_cache.o
ifeq ($(CONFIG_$(SPL_)RISCV_MMODE),y)
obj-$(CONFIG_$(SPL_)SIFIVE_CLINT) += sifive_clint.o
obj-$(CONFIG_$(SPL_)RISCV_ACLINT) += aclint_ipi.o
obj-$(CONFIG_ANDES_PLICSW) += andes_plicsw.o
else
obj-$(CONFIG_SBI) += sbi.o
Expand Down
16 changes: 8 additions & 8 deletions arch/riscv/lib/sifive_clint.c → arch/riscv/lib/aclint_ipi.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,44 +29,44 @@ int riscv_init_ipi(void)
struct udevice *dev;

ret = uclass_get_device_by_driver(UCLASS_TIMER,
DM_DRIVER_GET(sifive_clint), &dev);
DM_DRIVER_GET(riscv_aclint_timer), &dev);
if (ret)
return ret;

if (dev_get_driver_data(dev) != 0)
gd->arch.clint = dev_read_addr_ptr(dev);
gd->arch.aclint = dev_read_addr_ptr(dev);
else
gd->arch.clint = syscon_get_first_range(RISCV_SYSCON_CLINT);
gd->arch.aclint = syscon_get_first_range(RISCV_SYSCON_ACLINT);

if (!gd->arch.clint)
if (!gd->arch.aclint)
return -EINVAL;

return 0;
}

int riscv_send_ipi(int hart)
{
writel(1, (void __iomem *)MSIP_REG(gd->arch.clint, hart));
writel(1, (void __iomem *)MSIP_REG(gd->arch.aclint, hart));

return 0;
}

int riscv_clear_ipi(int hart)
{
writel(0, (void __iomem *)MSIP_REG(gd->arch.clint, hart));
writel(0, (void __iomem *)MSIP_REG(gd->arch.aclint, hart));

return 0;
}

int riscv_get_ipi(int hart, int *pending)
{
*pending = readl((void __iomem *)MSIP_REG(gd->arch.clint, hart));
*pending = readl((void __iomem *)MSIP_REG(gd->arch.aclint, hart));

return 0;
}

static const struct udevice_id riscv_aclint_swi_ids[] = {
{ .compatible = "riscv,aclint-mswi", .data = RISCV_SYSCON_CLINT },
{ .compatible = "riscv,aclint-mswi", .data = RISCV_SYSCON_ACLINT },
{ }
};

Expand Down
2 changes: 1 addition & 1 deletion board/openpiton/riscv64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SUPPORT_SPL
imply CPU_RISCV
imply RISCV_TIMER
imply SPL_SIFIVE_CLINT
imply SPL_RISCV_ACLINT
imply CMD_CPU
imply SPL_CPU_SUPPORT
imply SPL_SMP
Expand Down
2 changes: 1 addition & 1 deletion board/sipeed/maix/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ config BOARD_SPECIFIC_OPTIONS
imply SMP
imply DM_SERIAL
imply SIFIVE_SERIAL
imply SIFIVE_CLINT
imply RISCV_ACLINT
imply POWER_DOMAIN
imply SIMPLE_PM_BUS
imply CLK_K210
Expand Down
2 changes: 1 addition & 1 deletion drivers/timer/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ obj-$(CONFIG_RISCV_TIMER) += riscv_timer.o
obj-$(CONFIG_ROCKCHIP_TIMER) += rockchip_timer.o
obj-$(CONFIG_SANDBOX_TIMER) += sandbox_timer.o
obj-$(CONFIG_SP804_TIMER) += sp804_timer.o
obj-$(CONFIG_$(SPL_)SIFIVE_CLINT) += sifive_clint_timer.o
obj-$(CONFIG_$(SPL_)RISCV_ACLINT) += riscv_aclint_timer.o
obj-$(CONFIG_ARM_GLOBAL_TIMER) += arm_global_timer.o
obj-$(CONFIG_STM32_TIMER) += stm32_timer.o
obj-$(CONFIG_TEGRA_TIMER) += tegra-timer.o
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/* mtime register */
#define MTIME_REG(base, offset) ((ulong)(base) + (offset))

static u64 notrace sifive_clint_get_count(struct udevice *dev)
static u64 notrace riscv_aclint_timer_get_count(struct udevice *dev)
{
return readq((void __iomem *)MTIME_REG(dev_get_priv(dev),
dev_get_driver_data(dev)));
Expand All @@ -44,11 +44,11 @@ u64 notrace timer_early_get_count(void)
}
#endif

static const struct timer_ops sifive_clint_ops = {
.get_count = sifive_clint_get_count,
static const struct timer_ops riscv_aclint_timer_ops = {
.get_count = riscv_aclint_timer_get_count,
};

static int sifive_clint_probe(struct udevice *dev)
static int riscv_aclint_timer_probe(struct udevice *dev)
{
dev_set_priv(dev, dev_read_addr_ptr(dev));
if (!dev_get_priv(dev))
Expand All @@ -57,18 +57,18 @@ static int sifive_clint_probe(struct udevice *dev)
return timer_timebase_fallback(dev);
}

static const struct udevice_id sifive_clint_ids[] = {
static const struct udevice_id riscv_aclint_timer_ids[] = {
{ .compatible = "riscv,clint0", .data = CLINT_MTIME_OFFSET },
{ .compatible = "sifive,clint0", .data = CLINT_MTIME_OFFSET },
{ .compatible = "riscv,aclint-mtimer", .data = ACLINT_MTIME_OFFSET },
{ }
};

U_BOOT_DRIVER(sifive_clint) = {
.name = "sifive_clint",
U_BOOT_DRIVER(riscv_aclint_timer) = {
.name = "riscv_aclint_timer",
.id = UCLASS_TIMER,
.of_match = sifive_clint_ids,
.probe = sifive_clint_probe,
.ops = &sifive_clint_ops,
.of_match = riscv_aclint_timer_ids,
.probe = riscv_aclint_timer_probe,
.ops = &riscv_aclint_timer_ops,
.flags = DM_FLAG_PRE_RELOC,
};

0 comments on commit 2476058

Please sign in to comment.