Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception during peak finding #350

Open
arunpersaud opened this issue Aug 23, 2022 · 1 comment
Open

Exception during peak finding #350

arunpersaud opened this issue Aug 23, 2022 · 1 comment

Comments

@arunpersaud
Copy link

I ran into a problem where I have a spectrum that has a pileup in its largest bin and the resulting self.snr is constant for the last few bins... this creates a second derivative that d2=0, which raises and exception. Perhaps it's better to just print a warning, so that the program can continue?
Screen Shot 2022-08-23 at 10 00 31 AM

blue: spectrum
orange: self.snr from peakfinder

I'll submit a pull request in a minute for a possible code change

@arunpersaud
Copy link
Author

Just a quick not that after a discussion with the becquerel team we noticed that there is already code in there that should handle edge cases... I will check if that code can be improved to handle the above case as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant