Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cmake config errors/warnings #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes cmake config errors/warnings #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
project(gumbo_query CXX)
cmake_minimum_required(VERSION 3.2 FATAL_ERROR)
cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
cmake_policy(SET CMP0110 NEW)

include(CTest)
include(cmake/PreventInSourceBuilds.cmake)
Expand Down
5 changes: 0 additions & 5 deletions cmake/FindGumbo.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ find_library(Gumbo_LIBRARY
PATHS ${Gumbo_PKGCONF_LIBRARY_DIRS}
)

find_library(Gumbo_static_LIBRARY
NAMES libgumbo.a libgumbo_static.a gumbo.a gumbo_static.a libgumbo.lib libgumbo_static.lib gumbo.lib gumbo_static.lib
PATHS ${Gumbo_PKGCONF_LIBRARY_DIRS}
)

# Set the include dir variables and the libraries and let libfind_process do the rest.
# NOTE: Singular variables for this library, plural for libraries this this lib depends on.
set(Gumbo_PROCESS_INCLUDES Gumbo_INCLUDE_DIR)
Expand Down