feat: add telegram bot to lavap health #1862
Open
+202
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results2 268 tests - 120 2 265 ✅ - 123 25m 43s ⏱️ +6s For more details on these failures, see this check. Results for commit edbfa9b. ± Comparison against base commit 537c7ca. This pull request removes 125 and adds 5 tests. Note that renamed tests count towards both. |
shleikes
requested changes
Dec 23, 2024
| @@ -81,6 +82,7 @@ type Alerting struct { | |||
| suppressedAlerts uint64 // monitoring | |||
| payload map[string]interface{} | |||
| colorToggle bool | |||
| TelegramAlerting TelegramAlertingOptions | |||
There was a problem hiding this comment.
Why are you inherit and holding a TelegramAlertingOptions?
Comment on lines
+55
to
+56
| telegramBotTokenFlagName = "telegram-bot-token" | ||
| telegramChannelIDFlagName = "telegram-channel-id" |
There was a problem hiding this comment.
Change to telegram-alert-bot-token and telegram-alert-channel-id
Comment on lines
+252
to
+253
| cmdTestHealth.Flags().String(telegramBotTokenFlagName, "", "telegram bot token used for sending alerts to telegram channels (obtain from @BotFather)") | ||
| cmdTestHealth.Flags().String(telegramChannelIDFlagName, "", "telegram channel ID where alerts will be sent (must start with -100)") |
There was a problem hiding this comment.
I don't see where do you read this flag
Comment on lines
+166
to
+168
| if al.TelegramAlerting.TelegramBotToken != "" && al.TelegramAlerting.TelegramChannelID != "" { | ||
| al.SendTelegramAlert(alert, attrs) | ||
| } |
There was a problem hiding this comment.
You check this inside SendTelegramAlert
| @@ -161,6 +163,9 @@ func (al *Alerting) SendAlert(alert string, attributes []AlertAttribute) { | |||
| if al.url != "" { | |||
| go al.AppendUrlAlert(alert, attrs) | |||
| } | |||
| if al.TelegramAlerting.TelegramBotToken != "" && al.TelegramAlerting.TelegramChannelID != "" { | |||
| al.SendTelegramAlert(alert, attrs) | |||
There was a problem hiding this comment.
You don't do anything with the returned error?
| if err != nil { | ||
| return fmt.Errorf("failed to send telegram alert: %v", err) | ||
| } | ||
| defer resp.Body.Close() |
There was a problem hiding this comment.
Move the defer to line 48, right after resp, err := http.Post(url ...
Comment on lines
+39
to
+55
| checkRequest: func(t *testing.T, r *http.Request) { | ||
| // Check method and content type | ||
| assert.Equal(t, "POST", r.Method) | ||
| assert.Equal(t, "application/json", r.Header.Get("Content-Type")) | ||
|
|
||
| // Read and verify request body | ||
| body, err := io.ReadAll(r.Body) | ||
| require.NoError(t, err) | ||
|
|
||
| // Check if body contains expected content | ||
| bodyStr := string(body) | ||
| assert.Contains(t, bodyStr, "Test Alert") | ||
| assert.Contains(t, bodyStr, "severity") | ||
| assert.Contains(t, bodyStr, "high") | ||
| assert.Contains(t, bodyStr, "service") | ||
| assert.Contains(t, bodyStr, "test-service") | ||
| }, |
There was a problem hiding this comment.
Why is this here and not inside the test itself?
Comment on lines
+105
to
+107
| assert.Error(t, err) | ||
| } else { | ||
| assert.NoError(t, err) |
There was a problem hiding this comment.
Use require instead of assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...