Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unfreeze after new stake bug #1837

Merged
merged 6 commits into from
Dec 16, 2024
Merged

fix: unfreeze after new stake bug #1837

merged 6 commits into from
Dec 16, 2024

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

Fixed a bug in which when staking to a new chain, all the other provider's chains are unfrozen if their stake is above the min stake (which might be not preferable because the provider can freeze itself for maintenance)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Dec 15, 2024

Test Results

2 388 tests  +1   2 388 ✅ +2   25m 43s ⏱️ + 9m 52s
  122 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 7903158. ± Comparison against base commit ce4fadd.

♻️ This comment has been updated with latest results.

@oren-lava oren-lava closed this Dec 15, 2024
@oren-lava oren-lava force-pushed the fix-unfreeze-after-new-stake branch from 549c150 to c07dbc6 Compare December 15, 2024 14:02
@oren-lava oren-lava reopened this Dec 15, 2024
@Yaroms Yaroms merged commit 0c91449 into main Dec 16, 2024
29 checks passed
@Yaroms Yaroms deleted the fix-unfreeze-after-new-stake branch December 16, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants