Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Evmos Spec Champion BabyScope #17

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

BabyScope
Copy link
Contributor

@BabyScope BabyScope commented Oct 7, 2024

Hi Lava Foundation,

This is my submission for the Evmos Spec Champion. I am almost a year in the community and tried to help where i can. I help the communit as a support member and also running provider and a validator. I also helped with new specs and updated specs where needed. I also seperated Ethermint spec from the Evmos, because other chains are using Ethermint in there blockhcain as well. I updated the evmos spec and added middleware to the ibc spec. I also was the Champion for Benchmarking the Evmos RPC. I think with my knowledge and experience i am very capable to be the CHAMPION OF EVMOS SPEC.

Discord : BabyScope

1% - Support and run a provider
0.5% - Inherit, maintain and update Stargaze spec
1% - Provider support
1% - Benchmarking

@Yaroms
Copy link
Collaborator

Yaroms commented Oct 8, 2024

please make sure you have the following up to date list of supported apis:
rest:


"/evmos/erc20/v1/token_pairs"
"/evmos/evm/v1/params"
"/evmos/inflation/v1/params"
"/evmos/evm/v1/estimate_gas"
"/evmos/evm/v1/trace_block"
"/evmos/evm/v1/balances/{address}"
"/evmos/evm/v1/account/{address}"
"/evmos/vesting/v2/balances/{address}"
"/evmos/erc20/v1/token_pairs/{token}"
"/evmos/evm/v1/storage/{address}/{key}"
"/evmos/inflation/v1/period"
"/evmos/evm/v1/trace_tx"
"/evmos/inflation/v1/epoch_mint_provision"
"/evmos/inflation/v1/inflation_rate"
"/evmos/epochs/v1/current_epoch"
"/evmos/feemarket/v1/block_gas"
"/evmos/erc20/v1/params"
"/evmos/feemarket/v1/base_fee"
"/evmos/evm/v1/validator_account/{cons_address}"
"/evmos/feemarket/v1/params"
"/evmos/epochs/v1/epochs"
"/evmos/evm/v1/cosmos_account/{address}"
"/evmos/inflation/v1/circulating_supply"
"/evmos/evm/v1/eth_call"
"/evmos/evm/v1/codes/{address}"
"/evmos/inflation/v1/skipped_epochs"
"/evmos/evm/v1/base_fee"

grpc:


"evmos.epochs.v1.Query/CurrentEpoch"
"ethermint.evm.v1.Query/Code"
"evmos.inflation.v1.Query/InflationRate"
"ethermint.evm.v1.Query/Params"
"evmos.epochs.v1.Query/EpochInfos"
"ethermint.evm.v1.Query/CosmosAccount"
"ethermint.feemarket.v1.Query/BlockGas"
"evmos.vesting.v2.Query/Balances"
"evmos.erc20.v1.Query/Params"
"evmos.inflation.v1.Query/SkippedEpochs"
"evmos.erc20.v1.Query/TokenPair"
"ethermint.feemarket.v1.Query/BaseFee"
"ethermint.evm.v1.Query/ValidatorAccount"
"ethermint.evm.v1.Query/TraceBlock"
"evmos.inflation.v1.Query/Params"
"ethermint.evm.v1.Query/Account"
"ethermint.evm.v1.Query/TraceTx"
"ethermint.evm.v1.Query/EthCall"
"evmos.inflation.v1.Query/EpochMintProvision"
"ethermint.evm.v1.Query/EstimateGas"
"evmos.erc20.v1.Query/TokenPairs"
"evmos.inflation.v1.Query/CirculatingSupply"
"evmos.inflation.v1.Query/Period"
"ethermint.feemarket.v1.Query/Params"
"ethermint.evm.v1.Query/BaseFee"
"ethermint.evm.v1.Query/Storage"
"ethermint.evm.v1.Query/Balance"

mainnet-1/specs/ibs.json Outdated Show resolved Hide resolved
"contributor": [
"lava@18rtt3ka0jc85qvvcnct0t7ayq6fva7692k9kvh"
],
"contributor_percentage": 0.035
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"contributor_percentage": 0.035
"contributor_percentage": "0.035"

@BabyScope BabyScope requested a review from shleikes October 13, 2024 18:42
@@ -942,43 +942,6 @@
"type": "POST",
"add_on": "debug"
},
"apis": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these api needs to be disabled, they are inherited from ETH and are not available on evmos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yaroms Could you check the spec in this PR not on the mainnet-1/specs/evmos.json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am i missing something?
this PR is for mainnet-1/specs/evmos.json

"name": "minimum-gas-price",
"values": [
{
"expected_value": "CiQ1MDAwMDAwMDAwMC4wMDAwMDAwMDAwMDAwMDAwMDBhZXZtb3M",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should be udpated to: "CiQ1MDAwMDAwMDAwMC4wMDAwMDAwMDAwMDAwMDAwMDBhZXZtb3M="

is missing the "=" sign at the end.

@BabyScope BabyScope requested a review from ignacio-rsg October 31, 2024 19:36
@ignacio-rsg
Copy link
Collaborator

Please fix conflicts @BabyScope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants