build: updating docker provenance generator to use repo vars/secrets for docker registry access #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for docker registry access
cwaldren-ld
reviewed
Aug 5, 2024
.github/workflows/release-please.yml
Outdated
| secrets: | ||
| registry-password: ${{ secrets.GITHUB_TOKEN }} | ||
| registry-password: ${{ secrets.DOCKER_TOKEN }} |
There was a problem hiding this comment.
Add a newline and it should be good to merge 👍
cwaldren-ld
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Docker provenance generator needs repository credentials to publish provenance alongside the Docker image. However, the GITHUB_TOKEN referenced in the generator documentation doesn't work in our case, we need the same docker creds we use to publish the image in the first place.
Unfortunately, we can't safely pass credentials pulled from SSM in one workflow to the provenance generation workflow, so the most straightforward way to do this was configure the docker user/pass as a repository variable/secret via Terraform https://github.com/launchdarkly/terraform/pull/14600 and referencing it directly in the reusable workflow.
As a side note, we should be able to get rid of that SSM retrieval step now, but I want to make sure this works with the provenance generation workflow first to avoid breaking the build workflow.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.