Skip to content

Commit

Permalink
ci: use explicit relay version tag in Trivy Scan step (#344)
Browse files Browse the repository at this point in the history
It appears that our Trivy step that runs on each PR was scanning the
public image, rather than the locally built image related to the PR.
  • Loading branch information
cwaldren-ld authored Mar 14, 2024
1 parent 2539e4c commit ee8f98b
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,16 @@ jobs:
platforms: linux/amd64,linux/arm64/v8,linux/arm/v7,linux/386
- name: Build Docker Images
run: make products-for-release
- name: Get current Relay version
id: image-tag
run:
echo "value=$(jq -r '.version' < dist/metadata.json)" >> $GITHUB_OUTPUT
- uses: aquasecurity/trivy-action@master
with:
image-ref: launchdarkly/ld-relay:latest
# Using an explicit tag rather than ld-relay:latest to ensure we're scanning the local image that we just built.
# It's not clear why, but it seems goreleaser doesn't create the :latest tag when skipping the publish step
# as we do for CI, so the scan will end up checking the public image instead of the one we just built.
image-ref: launchdarkly/ld-relay:${{ steps.image-tag.outputs.value }}-amd64
format: 'table'
exit-code: '1'
ignore-unfixed: true

0 comments on commit ee8f98b

Please sign in to comment.