-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for client-side prerequisite events. #593
Conversation
if (value === undefined || value === null) { | ||
this.logger.debug('Result value is null. Providing default value.'); | ||
successDetail.value = defaultValue; | ||
} | ||
|
||
successDetail.prerequisites?.forEach((prereqKey) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send prerequisite events in order before the event for the variation. This matches server behavior.
}, | ||
eventFactory, | ||
); | ||
this.evaluateCb(flag, context, resolve, eventFactory); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change, but originally the cb version was added after the non-cb version. The interior code was the same, so the async eval can be implemented in terms of the callback eval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file updates because of unfortunate shared data. Not related to required updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file updates because of unfortunate shared data. Not related to required updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file updates because of unfortunate shared data. Not related to required updates.
We have decided to go with version B. |
This PR contains the server-side implementation for allFlagsState evaluation for bootstrap, server-side LDEvaluationDetail, client-side LDEvaluationDetail, and client-side events for prerequisites.
BEGIN_COMMIT_OVERRIDE
feat: Add support for client-side prerequisite events.
feat: Add support for prerequisite details to evaluation detail.
feat: Add prerequisite information to server-side allFlagsState.
END_COMMIT_OVERRIDE