Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove type modifiers on imports for better TS compatibility #346

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: remove type modifiers on imports for better TS compatibility #346

merged 1 commit into from
Jan 16, 2024

Conversation

ismaelgt
Copy link
Contributor

@ismaelgt ismaelgt commented Jan 11, 2024 •
edited
Loading

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

No new functionality has been added (only types import/export refactoring).

Related issues

#345 #347

Describe the solution you've provided

Remove the usage of type modifiers on import names to improve backwards compatibility with early versions of TypeScript.

Describe alternatives you've considered

The obvious solution would be upgrading the TypeScript version in the consumer, but this is not always easy (it's not in our case). More info here.

@ismaelgt ismaelgt changed the title fix: remove type modifiers on imports for better TS compatibility (#345) fix: remove type modifiers on imports for better TS compatibility Jan 11, 2024
@ismaelgt ismaelgt mentioned this pull request Jan 16, 2024
Closed
kinyoklion
kinyoklion approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Sorry for the delay in response.

@kinyoklion kinyoklion merged commit 3506349 into launchdarkly:main Jan 16, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
kinyoklion added a commit that referenced this pull request Jan 17, 2024
@github-actions @kinyoklion
chore: release main (#349)
2c6add5 
🤖 I have created a release *beep* *boop*
---


<details><summary>akamai-edgeworker-sdk-common: 1.0.6</summary>

##
[1.0.6](akamai-edgeworker-sdk-common-v1.0.5...akamai-edgeworker-sdk-common-v1.0.6)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from ^2.1.2 to ^2.1.3
</details>

<details><summary>akamai-server-base-sdk: 2.0.6</summary>

##
[2.0.6](akamai-server-base-sdk-v2.0.5...akamai-server-base-sdk-v2.0.6)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.0.5 to
^1.0.6
    * @launchdarkly/js-server-sdk-common bumped from ^2.1.2 to ^2.1.3
</details>

<details><summary>akamai-server-edgekv-sdk: 1.0.14</summary>

##
[1.0.14](akamai-server-edgekv-sdk-v1.0.13...akamai-server-edgekv-sdk-v1.0.14)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.0.5 to
^1.0.6
    * @launchdarkly/js-server-sdk-common bumped from ^2.1.2 to ^2.1.3
</details>

<details><summary>cloudflare-server-sdk: 2.3.3</summary>

##
[2.3.3](cloudflare-server-sdk-v2.3.2...cloudflare-server-sdk-v2.3.3)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.1.2 to 2.1.3
</details>

<details><summary>js-client-sdk-common: 0.1.2</summary>

##
[0.1.2](js-client-sdk-common-v0.1.1...js-client-sdk-common-v0.1.2)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-sdk-common bumped from 2.1.0 to 2.1.1
</details>

<details><summary>js-sdk-common: 2.1.1</summary>

##
[2.1.1](js-sdk-common-v2.1.0...js-sdk-common-v2.1.1)
(2024-01-16)


### Bug Fixes

* remove type modifiers on imports for better TS compatibility
([#346](#346))
([3506349](3506349))
* Treat 413 HTTP status as recoverable for events.
([#348](#348))
([4a6d4c3](4a6d4c3))
</details>

<details><summary>js-server-sdk-common: 2.1.3</summary>

##
[2.1.3](js-server-sdk-common-v2.1.2...js-server-sdk-common-v2.1.3)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-sdk-common bumped from 2.1.0 to 2.1.1
</details>

<details><summary>js-server-sdk-common-edge: 2.1.3</summary>

##
[2.1.3](js-server-sdk-common-edge-v2.1.2...js-server-sdk-common-edge-v2.1.3)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.1.2 to 2.1.3
</details>

<details><summary>node-server-sdk: 9.0.6</summary>

##
[9.0.6](node-server-sdk-v9.0.5...node-server-sdk-v9.0.6)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.1.2 to 2.1.3
</details>

<details><summary>node-server-sdk-dynamodb: 6.0.6</summary>

##
[6.0.6](node-server-sdk-dynamodb-v6.0.5...node-server-sdk-dynamodb-v6.0.6)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.0.5 to 9.0.6
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from 8.x to 9.0.6
</details>

<details><summary>node-server-sdk-redis: 4.0.6</summary>

##
[4.0.6](node-server-sdk-redis-v4.0.5...node-server-sdk-redis-v4.0.6)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.0.5 to 9.0.6
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from 8.x to 9.0.6
</details>

<details><summary>react-native-client-sdk: 0.1.5</summary>

##
[0.1.5](react-native-client-sdk-v0.1.4...react-native-client-sdk-v0.1.5)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk-common bumped from 0.1.1 to 0.1.2
</details>

<details><summary>vercel-server-sdk: 1.2.3</summary>

##
[1.2.3](vercel-server-sdk-v1.2.2...vercel-server-sdk-v1.2.3)
(2024-01-16)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.1.2 to 2.1.3
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Ryan Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinyoklion kinyoklion kinyoklion approved these changes

@yusinto yusinto Awaiting requested review from yusinto

@louis-launchdarkly louis-launchdarkly Awaiting requested review from louis-launchdarkly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismaelgt @kinyoklion