fix: propagate parsed model params into returned AI config #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
approved these changes
Dec 9, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Dec 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](ldai/v0.1.1...ldai/v0.2.0) (2024-12-09) ### ⚠ BREAKING CHANGES * Rename model and provider id to name ([#218](#218)) ### Bug Fixes * propagate parsed model params into returned AI config ([#220](#220)) ([f75b7a8](f75b7a8)) ### Code Refactoring * Rename model and provider id to name ([#218](#218)) ([ebdc281](ebdc281)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I had implemented parsing of model params/custom params, I forgot to invoke the proper builder methods to actually return them in the config.
I've added tests for this, as well as filled in some other testing gaps.