Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: call out indefinite blocking scenerio on StartAsync method #400

Merged
merged 2 commits into from
May 13, 2024

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented May 13, 2024

Since modifying the StartAsync method (which returns a future) would be a significant change to the API, we're adding docs instead to call out the "don't block indefinitely" scenario.

@cwaldren-ld cwaldren-ld marked this pull request as ready for review May 13, 2024 18:09
@cwaldren-ld cwaldren-ld requested a review from a team May 13, 2024 18:09
Co-authored-by: Matthew M. Keeler <[email protected]>
@cwaldren-ld cwaldren-ld merged commit b9b5d38 into main May 13, 2024
20 checks passed
@cwaldren-ld cwaldren-ld deleted the cw/sc-238485/startasync-docs branch May 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants