Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor Variation methods for correctness & clarity #203

Merged
merged 57 commits into from
Aug 25, 2023
Merged

fix: refactor Variation methods for correctness & clarity #203

merged 57 commits into from
Aug 25, 2023

Commits on Aug 21, 2023

  1. add <array> header

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    607024a View commit details
    Browse the repository at this point in the history

  2. add another missing <array>

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f49d534 View commit details
    Browse the repository at this point in the history

  3. rename sdk-contract-tests to client-contract-tests

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    53c8c54 View commit details
    Browse the repository at this point in the history

  4. copy client-side contract test server to server-side

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d14350b View commit details
    Browse the repository at this point in the history

  5. refactor contract tests data model into dedicated library

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f1ebea7 View commit details
    Browse the repository at this point in the history

  6. fix client name and version in contract test binaries

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    aa85920 View commit details
    Browse the repository at this point in the history

  7. update evaluation/evaluation detail commands to deserialize contexts

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    709c995 View commit details
    Browse the repository at this point in the history

  8. re-enable client-entity

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    5406b59 View commit details
    Browse the repository at this point in the history

  9. value-init data model types during deserialization

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e45741b View commit details
    Browse the repository at this point in the history

  10. add server Github action workflow

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    298c6d8 View commit details
    Browse the repository at this point in the history

  11. update client Github action workflow to fix contract test binary path

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d1976df View commit details
    Browse the repository at this point in the history

  12. be accepting of an empty PUT path

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    dbb541d View commit details
    Browse the repository at this point in the history

  13. more suppressions

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0b3f00a View commit details
    Browse the repository at this point in the history

  14. fix all custom event contract tests

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ac96b10 View commit details
    Browse the repository at this point in the history

  15. attempt to make CI run

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2d4e5b8 View commit details
    Browse the repository at this point in the history

  16. fix some event tests

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0829bca View commit details
    Browse the repository at this point in the history

  17. remove a bunch of suppressions

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e2d01df View commit details
    Browse the repository at this point in the history

  18. add missing version to feature events

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    37e604a View commit details
    Browse the repository at this point in the history

  19. fix debug event tests

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    22911a2 View commit details
    Browse the repository at this point in the history

  20. fix some feature event emission

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2ddf672 View commit details
    Browse the repository at this point in the history

  21. remove old PR branch from server.yml

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a41423f View commit details
    Browse the repository at this point in the history

  22. update comment

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d5ce5af View commit details
    Browse the repository at this point in the history

  23. add server.yml

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0145069 View commit details
    Browse the repository at this point in the history

  24. initial implementation of AllFlagsState method and structs

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    57f5f9c View commit details
    Browse the repository at this point in the history

  25. begin adding unit tests

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e9c068d View commit details
    Browse the repository at this point in the history

  26. unsupress contract tests due to lack of AllFlagsState API

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e578ad1 View commit details
    Browse the repository at this point in the history

  27. cleanup AllFlagsState api and types

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9b9a984 View commit details
    Browse the repository at this point in the history

  28. doc comments on AllFlagsState

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    796ff70 View commit details
    Browse the repository at this point in the history

  29. renamings

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3713595 View commit details
    Browse the repository at this point in the history

  30. refactor AllFlagsStateOptions into enum nested in AllFlagsState struct

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    144d705 View commit details
    Browse the repository at this point in the history

  31. fix build

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    059b21a View commit details
    Browse the repository at this point in the history

  32. fix regressed test

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    43f27cb View commit details
    Browse the repository at this point in the history

  33. revert change to DetailsOnlyForTrackedFlags unit test

    @cwaldren-ld
    cwaldren-ld committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    07663f7 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. only return empty AllFlagsState if not initialized and memory store u… 

    …navailable
    @cwaldren-ld
    cwaldren-ld committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    daef5cb View commit details
    Browse the repository at this point in the history

  2. additional suppressions for bucketing

    @cwaldren-ld
    cwaldren-ld committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    47ad8bb View commit details
    Browse the repository at this point in the history

  3. refactor variation methods to separate out event generation

    @cwaldren-ld
    cwaldren-ld committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ca9a74e View commit details
    Browse the repository at this point in the history

  4. refactor IsExperimentationEnabled into data_model::Flag

    @cwaldren-ld
    cwaldren-ld committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d5cd0fa View commit details
    Browse the repository at this point in the history

  5. remove a bunch of evaluation suppressions

    @cwaldren-ld
    cwaldren-ld committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    219d7a9 View commit details
    Browse the repository at this point in the history

  6. remove some event suppressions

    @cwaldren-ld
    cwaldren-ld committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    33944c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. remove more event suppressions

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    41a9e4c View commit details
    Browse the repository at this point in the history

  2. remove obsolete methods

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    14e0c14 View commit details
    Browse the repository at this point in the history

  3. better encapsulation of EventScope

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1a3a405 View commit details
    Browse the repository at this point in the history

  4. re-add variation call logging

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d8754a5 View commit details
    Browse the repository at this point in the history

  5. const correctness for EventScope

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    405693f View commit details
    Browse the repository at this point in the history

  6. add const to LogVariationCall

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1cf9666 View commit details
    Browse the repository at this point in the history

  7. refactor event scope to pass IEventProcessor in callback

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4ce9dc9 View commit details
    Browse the repository at this point in the history

  8. remove disabled bool from EventScope and rely on polymorphism

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    63e3ad1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'server-side' into cw/sc-213848/refactor-variation-methods

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    275b238 View commit details
    Browse the repository at this point in the history

  10. rename EventScope::Get to Send

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2e49214 View commit details
    Browse the repository at this point in the history

  11. remove NullEventProcessor from server-side SDK and document EventScope

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5b7e08e View commit details
    Browse the repository at this point in the history

  12. feat: implement prerequisite event recording (#204) 

    Implements prerequisite event recording, and fixes some bugs related to
prereq event generation.
    @cwaldren-ld
    cwaldren-ld authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a6589e7 View commit details
    Browse the repository at this point in the history

  13. add unit tests for EventScope

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6b1f647 View commit details
    Browse the repository at this point in the history

  14. fix evaluator tests

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    15f362e View commit details
    Browse the repository at this point in the history

  15. add some event factory tests

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b1d1398 View commit details
    Browse the repository at this point in the history

  16. typo

    @cwaldren-ld
    cwaldren-ld committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8b0fbac View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Merge branch 'server-side' into cw/sc-213848/refactor-variation-methods

    @cwaldren-ld
    cwaldren-ld committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    73b8900 View commit details
    Browse the repository at this point in the history

  2. fix a lint

    @cwaldren-ld
    cwaldren-ld committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1cf17bb View commit details
    Browse the repository at this point in the history