Skip to content
lint

fix: Summarizer::VariationKey operator< was unsound #1735

Sign in to view logs

fix: Summarizer::VariationKey operator< was unsound

fix: Summarizer::VariationKey operator< was unsound #1735

Triggered via pull request June 1, 2024 00:50
@cwaldren-ldcwaldren-ld
synchronize #412
cw/sc-246162/unsound-comparison-op
Status Success
Total duration 2m 21s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
2m 8s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
/libs/internal/include/launchdarkly/events/detail/summarizer.hpp:94:15 [readability-else-after-return]: libs/internal/include/launchdarkly/events/detail/summarizer.hpp#L94
do not use 'else' after 'return'
/libs/internal/tests/event_summarizer_test.cpp:33:57 [cppcoreguidelines-avoid-magic-numbers: libs/internal/tests/event_summarizer_test.cpp#L33
12345 is a magic number; consider replacing it with a named constant
/libs/internal/tests/event_summarizer_test.cpp:39:30 [readability-identifier-length]: libs/internal/tests/event_summarizer_test.cpp#L39
variable name 'a' is too short, expected at least 3 characters
/libs/internal/tests/event_summarizer_test.cpp:40:30 [readability-identifier-length]: libs/internal/tests/event_summarizer_test.cpp#L40
variable name 'b' is too short, expected at least 3 characters
/libs/internal/tests/event_summarizer_test.cpp:52:1 [readability-function-cognitive-complexity]: libs/internal/tests/event_summarizer_test.cpp#L52
function 'TestBody' has cognitive complexity of 61 (threshold 25)
/libs/internal/tests/event_summarizer_test.cpp:60:34 [cppcoreguidelines-avoid-magic-numbers: libs/internal/tests/event_summarizer_test.cpp#L60
12412 is a magic number; consider replacing it with a named constant
/libs/internal/tests/event_summarizer_test.cpp:60:41 [cppcoreguidelines-avoid-magic-numbers: libs/internal/tests/event_summarizer_test.cpp#L60
123 is a magic number; consider replacing it with a named constant
/libs/internal/tests/event_summarizer_test.cpp:61:34 [cppcoreguidelines-avoid-magic-numbers: libs/internal/tests/event_summarizer_test.cpp#L61
324 is a magic number; consider replacing it with a named constant
/libs/internal/tests/event_summarizer_test.cpp:61:39 [cppcoreguidelines-avoid-magic-numbers: libs/internal/tests/event_summarizer_test.cpp#L61
5323332 is a magic number; consider replacing it with a named constant
/libs/internal/tests/event_summarizer_test.cpp:64:34 [readability-identifier-length]: libs/internal/tests/event_summarizer_test.cpp#L64
variable name 'a' is too short, expected at least 3 characters