Skip to content
lint

fix: refactor Variation methods for correctness & clarity #905

Sign in to view logs

fix: refactor Variation methods for correctness & clarity

fix: refactor Variation methods for correctness & clarity #905

Triggered via pull request August 23, 2023 21:58
@cwaldren-ldcwaldren-ld
synchronize #203
cw/sc-213848/refactor-variation-methods
Status Success
Total duration 3m 27s
Artifacts –
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

cpp-linter.yml

on: pull_request
cpp-linter
3m 17s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
/libs/internal/include/launchdarkly/data_model/flag.hpp:25:12 [cppcoreguidelines-pro-type-member-init]: libs/internal/include/launchdarkly/data_model/flag.hpp#L25
constructor does not initialize these fields: kind
/libs/internal/src/../include/launchdarkly/data_model/flag.hpp:39:13 [readability-inconsistent-declaration-parameter-name]: libs/internal/src/../include/launchdarkly/data_model/flag.hpp#L39
function 'launchdarkly::data_model::Flag::Rollout::WeightedVariation::WeightedVariation' has a definition with different parameter names
/libs/internal/src/../include/launchdarkly/data_model/flag.hpp:40:38 [readability-inconsistent-declaration-parameter-name]: libs/internal/src/../include/launchdarkly/data_model/flag.hpp#L40
function 'launchdarkly::data_model::Flag::Rollout::WeightedVariation::Untracked' has a definition with different parameter names
/libs/internal/src/../include/launchdarkly/data_model/flag.hpp:43:13 [readability-inconsistent-declaration-parameter-name]: libs/internal/src/../include/launchdarkly/data_model/flag.hpp#L43
function 'launchdarkly::data_model::Flag::Rollout::WeightedVariation::WeightedVariation' has a definition with different parameter names
/libs/internal/src/data_model/flag.cpp:9:53 [bugprone-easily-swappable-parameters]: libs/internal/src/data_model/flag.cpp#L9
2 adjacent parameters of 'WeightedVariation' of similar type are easily swapped by mistake
/libs/internal/src/data_model/flag.cpp:45:36 [bugprone-unchecked-optional-access]: libs/internal/src/data_model/flag.cpp#L45
unchecked access to optional value
/home/runner/boost/boost/boost/include/boost/smart_ptr/detail/shared_count.hpp:612:26 [clang-analyzer-cplusplus.NewDelete]: home/runner/boost/boost/boost/include/boost/smart_ptr/detail/shared_count.hpp#L612
Use of memory after it is freed
/libs/server-sdk/src/client_impl.cpp:85:34 [performance-unnecessary-value-param]: libs/server-sdk/src/client_impl.cpp#L85
the parameter 'exec' is copied for each invocation but only used as a const reference; consider making it a const reference
/libs/server-sdk/src/client_impl.cpp:102:31 [performance-unnecessary-value-param]: libs/server-sdk/src/client_impl.cpp#L102
the parameter 'config' is copied for each invocation but only used as a const reference; consider making it a const reference
/libs/server-sdk/src/client_impl.cpp:113:7 [readability-redundant-member-init]: libs/server-sdk/src/client_impl.cpp#L113
initializer for member 'memory_store_' is redundant