Skip to content
lint

fix: improve handling of streaming error state changes/logging (#439) #1813

Sign in to view logs

fix: improve handling of streaming error state changes/logging (#439)

fix: improve handling of streaming error state changes/logging (#439) #1813

Triggered via push September 30, 2024 19:48
@cwaldren-ldcwaldren-ld
pushed 04e7e0e
main
Status Success
Total duration 5m 17s
Artifacts –

cpp-linter.yml

on: push
cpp-linter
5m 5s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:24:5 [modernize-pass-by-value]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L24
pass by value and use std::move
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:26:5 [modernize-pass-by-value]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L26
pass by value and use std::move
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:27:5 [modernize-pass-by-value]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L27
pass by value and use std::move
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:32:13 [performance-unnecessary-value-param]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L32
parameter 'ioc' is passed by value and only copied once; consider moving it to avoid unnecessary copies
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:102:54 [cppcoreguidelines-avoid-magic-numbers: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L102
5 is a magic number; consider replacing it with a named constant
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:174:72 [bugprone-branch-clone]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L174
repeated branch in conditional chain
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:178:21 [performance-move-const-arg]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L178
std::move of the const variable 'error_string' has no effect; remove std::move() or make the variable non-const
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:187:21 [performance-move-const-arg]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L187
std::move of the const variable 'error_string' has no effect; remove std::move() or make the variable non-const
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:194:21 [performance-move-const-arg]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L194
std::move of the const variable 'error_string' has no effect; remove std::move() or make the variable non-const
/libs/client-sdk/src/data_sources/streaming_data_source.cpp:201:21 [performance-move-const-arg]: libs/client-sdk/src/data_sources/streaming_data_source.cpp#L201
std::move of the const variable 'error_string' has no effect; remove std::move() or make the variable non-const