fix: handle setting protected/type-enforced attributes correctly #1799
cwaldren-ldAnnotations
4 warnings and 3 notices
|
/libs/common/include/launchdarkly/attributes_builder.hpp:54:14 [readability-qualified-auto]:
libs/common/include/launchdarkly/attributes_builder.hpp#L54
'auto &pair' can be declared as 'const auto &pair'
|
|
/libs/common/include/launchdarkly/attributes_builder.hpp:69:5 [performance-noexcept-move-constructor]:
libs/common/include/launchdarkly/attributes_builder.hpp#L69
move constructors should be marked noexcept
|
|
/libs/common/include/launchdarkly/attributes_builder.hpp:226:5 [modernize-use-nodiscard]:
libs/common/include/launchdarkly/attributes_builder.hpp#L226
function 'BuildAttributes' should be marked [[nodiscard]]
|
|
cpp-linter
The following actions use a deprecated Node.js version and will be forced to run on node20: MarkusJx/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run clang-format on libs/common/include/launchdarkly/attributes_builder.hpp:
libs/common/include/launchdarkly/attributes_builder.hpp#L1
File libs/common/include/launchdarkly/attributes_builder.hpp does not conform to Custom style guidelines. (lines 23, 34, 214, 230, 241)
|
|
Run clang-format on libs/common/src/attributes_builder.cpp:
libs/common/src/attributes_builder.cpp#L1
File libs/common/src/attributes_builder.cpp does not conform to Custom style guidelines. (lines 4, 27, 28, 29, 30, 40, 42, 43, 44, 46, 50, 51, 52, 53, 54, 57, 58, 59, 60, 61, 62, 63, 64, 65, 67, 68, 69, 70, 71, 72, 73, 76, 92, 111, 112, 119, 133, 137)
|
|
Run clang-format on libs/common/tests/context_builder_test.cpp:
libs/common/tests/context_builder_test.cpp#L1
File libs/common/tests/context_builder_test.cpp does not conform to Custom style guidelines. (lines 31, 32, 33, 34, 35, 36, 37, 38, 58, 59, 60, 61, 62, 63, 64, 65, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 96, 179, 180, 181, 182, 183, 199, 200, 202, 203, 208, 209, 210, 211, 250, 251, 260, 261, 272, 273, 283, 284, 292, 293, 295, 296, 297, 298)
|