Recover from various issues #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents might contain slightly out of sync token structures, when artificial tokens were inserted in one but not the other. To keep the program running, we enter something like an empty word, which is effective, but can also be problematic in the final reports: When a word is present only in the reviewable file, we cannot keep track of it in the diff report.
... and put something that indicates emptiness ('-') there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
We have problems when documents are not in sync regarding their token structure. This can happen even with valid documents, such as when Arethusa inserts elliptic nodes.
There were also errors when partially unannotated documents were supplied (missing attributes, or in the case of the postag also an empty string). This is also taken care of here.
While these minor changes keep the application running and not throwing exceptions, there are some follow-up problems with it. A new issue will deal with them.