-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numerous \DeclareFontSeriesChangeRule
entries
#1396
base: develop
Are you sure you want to change the base?
Conversation
The rules are now sorted by weight (from 'ul' to 'ub') and width (from 'uc' to 'ux')
The rules are now sorted by weight (from 'ul' to 'ub') and width (from 'uc' to 'ux')
The rules are now sorted in the same way as the 'm?'/'?m' rules
Rules are unnecessary because requested series and target series are identical
…f weights (from 'ul' to 'ub') and widths (from 'uc' to 'ux') is covered
…imilar rules also have an alternative target series)
These 'l' rules seem reasonable and are similar to the 'b' rules
Requested series and target series are identical. If this series does not exist, the normal substitution mechanism will substitute \seriesdeafult, which is usually m (and if it's not m, then it was probably changed for a good reason). So no need for these rules.
similar to previous commit
I'm going to look at this once you say it is ready, but not before returning from Prague, ie not before August. Fixing the conflict is probably not sensible right now as it will conflict again during the next weeks. |
And it should get a (draft) entry in ltnews40, at least a placeholder so that it is not forgotten, thanks. |
base/ltfssaxes.dtx
Outdated
% in the end (324 entries) but on the other hand it doesn't change and | ||
% With 9 weight values (from \texttt{ul} to \texttt{ub}) and 9 width values | ||
% (from \texttt{uc} to \texttt{ux}), this table is getting a bit large in | ||
% the end (1345 entries), but on the other hand it doesn't change and | ||
% accessing speed and it is fast this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An incomplete sentence: "but on the other hand it doesn't change and accessing speed and it is fast this way." What was that originally supposed to mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the intended meaning is along the lines of this, which might be clearer?
this table is now rather large (1345 entries), but on the other hand, the table doesn't change and accessing rules is fast using a table implemented in this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rephrased the sentence accordingly.
@@ -35,7 +35,7 @@ | |||
% | |||
% | |||
\ProvidesFile{ltfssaxes.dtx} | |||
[2024/02/08 v1.0i LaTeX Kernel (NFSS Axes handing)] | |||
[2024/07/01 v1.0j LaTeX Kernel (NFSS Axes handing)] | |||
% \iffalse | |||
\documentclass{ltxdoc} | |||
\begin{document} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another incomplete sentence (a few lines further down, seems I can't comment there): "This file contains the implementation for handling extra axes splitting the series and the values into sub-categories. selection commands." What was that originally supposed to mean?
base/ltfssaxes.dtx
Outdated
\DeclareFontSeriesChangeRule {l}{ex}{lex} {l} % ? %<----- | ||
\DeclareFontSeriesChangeRule {l}{ux}{lux} {l} % ? %<----- | ||
\DeclareFontSeriesChangeRule {l}{sb}{sb} {b} % ? %<----- | ||
\DeclareFontSeriesChangeRule {l}{b}{b} {bx} %<----- | ||
\DeclareFontSeriesChangeRule {l}{bx}{bx} {b} %<----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of entries of the form \DeclareFontSeriesChangeRule{...}{...}{bx}{b}
. I suspect that they exist because for the Computer Modern fonts 'bold' is bx
and not b
, so that you have a reasonable substitution when bx
is applied to another font. Wouldn't it be better if this was handled in a general way, e.g., in \merge@font@series@
, instead of handling this case (incompletely) via random \DeclareFontSeriesChangeRule
entries?
@FrankMittelbach I've added an entry in ltnews40. Minor open questions in the comments above, otherwise this PR is ready for review. |
Ignore this comment. It's only here because I can't figure out how to watch a PR. (If this gets merged, I can probably remove some code from |
@cfr42 There is this button in the right-hand sidebar (If you're opening GitHub on a mobile device, it's at the bottom of the page.) |
Thanks! For some reason, I did not make that terminological connection, despite seeing the button. (I tried various other things, but not that one.) |
LaTeX is currently missing some
\DeclareFontSeriesChangeRule
entries. Consider the following example:Furthermore, it is documented that not all widths are yet supported:
This PR adds rules so that the full range of weights (from
ul
toub
) and widths (fromuc
toux
) is covered. The entries are sorted first by weight (fromul
toub
) and then by width (fromuc
toux
). (Perhaps this gives a little structure to the long list of entries.)Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updated