Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Simplify kryoptic build #473

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Nov 22, 2024

Description

Kryoptic supports linking against system OpenSSL, which should be much faster than rebuilding the whole OpenSSL.

I do not think we need the build against specific OpenSSL version now.

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@Jakuje Jakuje marked this pull request as draft November 22, 2024 11:35
@Jakuje Jakuje marked this pull request as ready for review November 22, 2024 14:35
@Jakuje
Copy link
Contributor Author

Jakuje commented Nov 22, 2024

Ok, not ready yet. The tls test fails now with kryoptic when we force all operations to the token

########################################
## Forcing the provider for all server operations


## Run sanity test with default values (RSA)
...
80C2517DC77F0000:error:40800054:pkcs11:p11prov_GetOperationState:reason(84):../src/interface.gen.c:335:Error returned by C_GetOperationState

Not sure if this is the relevant error or something else got broken (or the dynamic feature messes up the openssl context). Will have to investigate further.

Kryoptic supports linking against system OpenSSL, which should
be much faster than rebuilding the whole OpenSSL.

Signed-off-by: Jakub Jelen <[email protected]>
@Jakuje Jakuje marked this pull request as draft November 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant