Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: refactor server/utils #16

Merged
merged 1 commit into from
Sep 22, 2024
Merged

server: refactor server/utils #16

merged 1 commit into from
Sep 22, 2024

Conversation

mertcandav
Copy link
Contributor

This PR refactors server/utils package.

Having such a utils package is bad practice. So this PR removes this package.
There are two files: slices.go and validator.go.

The slices.go file implements basic Contains function for slices. But it is duplicated and is not necessary since does nothing different. Therefore this PR uses the slices standard package of Go for same functionality.

For validator.go, it brings validate package with minor improvement.

lareii
lareii approved these changes Sep 22, 2024
View reviewed changes
Copy link
Owner

@lareii lareii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@lareii lareii merged commit 347da13 into lareii:master Sep 22, 2024
1 check passed
@lareii lareii added the proposal A proposal for new feature or changings label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lareii lareii lareii approved these changes

Assignees
No one assigned
Labels
proposal A proposal for new feature or changings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mertcandav @lareii