Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix features options setting WslApplyFeatures.php #1983

Open
wants to merge 1 commit into
base: wsl-rework
Choose a base branch
from
Open

Fix features options setting WslApplyFeatures.php #1983

wants to merge 1 commit into from

Conversation

sdespont
Copy link
Contributor

Because the features options are set in the environnement variables in

homestead/scripts/homestead.rb

Lines 308 to 311 in 98a798b

config.vm.provision "shell" do |s|
s.name = "Installing " + feature_name
s.path = feature_path
s.env = feature_variables

it must be the same in the WSL code

@sdespont
Fix features options setting WslApplyFeatures.php
f21aebb 
Because the features options are set in the evnirronement variables in https://github.com/laravel/homestead/blob/98a798b18a078121252f0ecfe3e10cba050ce504/scripts/homestead.rb#L308-L311

it must be the same in the WSL code
@sdespont
Copy link
Contributor Author

Could you consider merging this request?

@sdespont
Copy link
Contributor Author

@svpernova09 Could you consider merging this request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sdespont