Ngrok default param for apache share #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svpernova09
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Seems safe as long as users avoid https://manpages.ubuntu.com/manpages/focal/man1/sshare.1.html :D
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like trying to share an apache site won't work without adding this param.
From what I've tested this has no effect on nginx but will fix it working for apache so defaulting this won't have any negative effects and will work for both.
I've also included an alias for share over port 443 as well
sshare(secure share) but if you're not happy with this I can remove it.