Fix random matrix #734
Merged
Fix random matrix #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new code randomly selects column indexes to create a random sparse matrix for the sparse formats.
… matrices. * Minor edits to function for creating random sparse matrices. * Bug fixes and updates to ellblock format to support new random sparse data.
oseikuffuor1
requested review from
nicolasbock,
cnegre,
suemni,
tokshgithub and
jmohdyusof
as code owners
jeanlucf22
reviewed
Sep 29, 2023
suemni
approved these changes
Sep 29, 2023
jeanlucf22
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new strategy for constructing sparse (arbitrary) random matrices. This fixes issues with the previous approach that assumed the column indexes per row are contiguous (as in dense matrices). The PR also corrects potential issues with our test framework due to the above assumption. This PR resolves issue #715.