Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyLIQTR update and refactoring #50

Merged
merged 8 commits into from
Aug 5, 2024
Merged

PyLIQTR update and refactoring #50

merged 8 commits into from
Aug 5, 2024

Conversation

JonhasSC
Copy link
Collaborator

Updating pyLIQTR to 1.2.0 which is their latest version. As LL don't follow semantic version, I'm not confident not specifying a specific version for it. Additionally, removed any functionality that has been removed as of 1.2.0 which is print_to_openqasm.

Reran notebooks to guarantee that they function with latest update.

@JonhasSC JonhasSC requested a review from zmorrell July 22, 2024 21:53
@zmorrell
Copy link
Collaborator

Did anything need to be changed in the notebooks for them to be run properly? If so, I would imagine that we may need to modify the scripts as well.

@zmorrell
Copy link
Collaborator

zmorrell commented Aug 5, 2024

Since no changes were made to the notebooks and the only main changes appear to be updating dependencies, this looks safe to merge.

@zmorrell zmorrell merged commit 0b56eaa into dev Aug 5, 2024
@JonhasSC JonhasSC deleted the enhancement/update-pyLIQTR branch August 5, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants