FIX: radiality constraint for multiple switches between blocks #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the edge case where there are more than one switch between the same two neighboring blocks. Adds unit tests to ensure that when radiality constraints are enabled that switches can be either all open, or only one can be closed. EzXML dependency change broke a unit test. Resolves #13
Changes graphml tests to use EzXML rather than relying on line count, which could change based on factors outside of the data sets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 80.79% 81.64% +0.84%
==========================================
Files 45 45
Lines 5327 5328 +1
==========================================
+ Hits 4304 4350 +46
+ Misses 1023 978 -45 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the edge case where there are more than one switch between the same two neighboring blocks.
Adds unit tests to ensure that when radiality constraints are enabled that switches can be either all open, or only one can be closed.
EzXML dependency change broke a unit test.
Resolves #13