-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename flows on main page and by clicking header #5525
Open
lucaseduoli
wants to merge
9
commits into
main
Choose a base branch
from
feat/rename-flows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+270
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
enhancement
New feature or request
javascript
Pull requests that update Javascript code
labels
Jan 2, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 2, 2025
Cristhianzl
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests to validate this change?
I think It can be on core tests > extended > features
src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
Outdated
Show resolved
Hide resolved
anovazzi1
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…/FlowMenu/index.tsx Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
…/FlowMenu/index.tsx Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
…/FlowMenu/index.tsx Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 3, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
javascript
Pull requests that update Javascript code
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the flow management components in the frontend. The key changes include the addition of an inline flow name editing feature, improvements to the flow settings modal, and updates to the dropdown component to support editing flow details.
Inline Flow Name Editing:
MenuBar
component. This includes the use ofuseEffect
,useState
,useRef
, and event handlers for input changes and key events. (src/frontend/src/components/core/appHeaderComponent/components/FlowMenu/index.tsx
) [1] [2] [3] [4] [5] [6] [7] [8]Flow Settings Modal Enhancements:
FlowSettingsModal
component to acceptflowData
as a prop and updated the state initialization and handlers to use this prop. This allows the modal to be reused with different flow data. (src/frontend/src/modals/flowSettingsModal/index.tsx
) [1] [2]Dropdown Component Updates:
handleEdit
prop to theDropdownComponent
and updated theuseSelectOptionsChange
hook to handle the "edit" action. This enables the dropdown menu to trigger the flow settings modal for editing flow details. (src/frontend/src/pages/MainPage/components/dropdown/index.tsx
,src/frontend/src/pages/MainPage/hooks/use-select-options-change.tsx
) [1] [2] [3] [4] [5]Integration with Grid and List Components:
GridComponent
andListComponent
. This includes adding state for the modal and passing thehandleEdit
function to the dropdown component. (src/frontend/src/pages/MainPage/components/grid/index.tsx
,src/frontend/src/pages/MainPage/components/list/index.tsx
) [1] [2] [3] [4] [5] [6] [7] [8]Type Definitions:
FlowSettingsPropsType
to include an optionalflowData
property, allowing the flow settings modal to be more flexible. (src/frontend/src/types/components/index.ts
)