-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add architecture-specific docker tags #5474
base: main
Are you sure you want to change the base?
feat: add architecture-specific docker tags #5474
Conversation
@robwilkes To my understanding, the appropriate image for your platform should be automatically selected when running Of course, this is a moot point now given that we have only built for amd64. https://hub.docker.com/r/langflowai/langflow/tags. Future builds should include arm64 as well, and the appropriate image will be pulled based on your platform. Do you agree with that, or are there other benefits to tagging with the architecture you see? |
@jordanrfrazier are you sure you've never built for arm64? I'm confused by the status tbh. #1976 talks about this as if it's a new feature/request The change specified in the issue: Was already merged: And a new build initiated, which took 26 minutes. However there is no arm64 image on Docker Hub. I can see in the action logs that it included the additional platform(s) https://github.com/langflow-ai/langflow/actions/runs/12036413622/job/33557616776
However no arm64 image on Docker Hub. I also found somebody tried to do it back in June: It seems some arm64 images were pushed back then, so if you reimplement whatever was done back then it should be fine without this. Other PRs relating to arm64 were recently closed as well, stating it's now supported, however despite these changes, and subsequent builds conducted, there is still no arm64 images on Docker Hub. Feel free to test your arm64 builds without this, and reconsider this if arm64 images don't appear on Docker Hub, or find an alternative solution which pushes both under the same tag(s). |
Architecture-specific Docker tags
Changes
-amd64
,-arm64
) for Docker imagesWhy
Currently, the
latest
tag defaults to amd64, making it difficult for ARM64 users to pull the correct image. This change makes it explicit which architecture each image is built for.Testing
Tested in fork by:
Notes