Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve naming consistency in DataCombiner component #5471

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

raphaelchristi
Copy link
Contributor

This PR improves the naming consistency in the data combination component by:

  • Removing redundant "Merge" terminology since it's an operation type
  • Renaming component to DataCombinerComponent for better clarity
  • Converting operation enum values to uppercase
  • Maintaining consistent terminology around "combine" vs "merge"

Changes:

  • Renamed MergeOperation -> DataOperation
  • Renamed MergeDataComponent -> DataCombinerComponent
  • Changed enum values to uppercase (CONCATENATE, APPEND, etc)
  • Updated method names for consistency (merge_data -> combine_data)
  • Updated display names and documentation

- Rename MergeOperation to DataOperation
- Rename component to DataCombinerComponent
- Convert operation enum values to uppercase
- Update method names for consistency
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 27, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Dec 27, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 27, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 27, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 27, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant