Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Unified EmbeddingStoreAutoConfigurationIT #29

Closed
wants to merge 3 commits into from
Closed

[Feature] Unified EmbeddingStoreAutoConfigurationIT #29

wants to merge 3 commits into from

Conversation

Martin7-1
Copy link
Contributor

  1. This PR introducing common test EmbeddingStoreAutoConfigurationIT for all AutoConfiguration of EmbeddingStore.
  2. This PR add langchain4j-bom to manage dependencies of langchain4j.

Note: This PR should be merged before #2 , #27 and #28 .

This was referenced Jun 22, 2024
Merged
Merged
Merged
@Martin7-1 Martin7-1 closed this Jun 22, 2024
@langchain4j
Copy link
Owner

Hi, was this closed by mistake?

@Martin7-1
Copy link
Contributor Author

Hi, was this closed by mistake?

No. This PR closed because I think EmbeddingStoreAutoConfigurationIT does not belong to langchain4j-spring-boot-starter, so I create a new module named langchain4j-spring-boot-core. You can see it in any {EmbeddingStoreName}EmbeddingStoreAutoConfiguration PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martin7-1 @langchain4j