-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Baseline: Spring Boot 3 and Java 17 #24
New Baseline: Spring Boot 3 and Java 17 #24
Conversation
@langchain4j what do you think? The tests are failing because the values from the environment variables are empty (e.g. the OpenAI API Key). I'm not sure why. |
@ThomasVitale thank you, looks good! |
Right, that makes sense. Next time, I'll create a branch directly from here instead of a fork. |
@ThomasVitale can't make it inject secrets from the fork :( I have run it locally, tests in anthropic are failing with
This is probably due to |
@langchain4j I'll have a look, thanks |
It looks like the JUnit Pioneer dependency doesn't support running with Spring Boot 3 (junit-pioneer/junit-pioneer#810). I'll see if I can find some workaround. |
* Minimum supported version of Java is now 17 * Minimum supported version of Spring Boot is now 3.2 Spring Boot versions older than 3.2 reached EOL and will not receive any further support nor security patches. It would be a security risk to continue using EOL-ed versions in this LangChain4j project. More information: https://spring.io/projects/spring-boot#support Signed-off-by: Thomas Vitale <[email protected]>
aa58c62
to
d069ea1
Compare
@langchain4j as agreed, I updated the PR removing the JUnit Pioneer extension. I couldn't reproduce the error on a Spring Boot app created from start.spring.io, so it's probably something specific to the project setup involving Maven SureFire, Java 17 and Spring Boot 3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasVitale thank you!
Spring Boot versions older than 3.2 reached EOL and will not receive any further support nor security patches. It would be a security risk to continue using EOL-ed versions in this LangChain4j project.
More information: https://spring.io/projects/spring-boot#support