Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] More Informative Errors #938

Merged
merged 6 commits into from
Aug 22, 2024
Merged

[JS] More Informative Errors #938

merged 6 commits into from
Aug 22, 2024

Conversation

hinthornw
Copy link
Collaborator

@hinthornw hinthornw commented Aug 21, 2024 •
edited
Loading

  1. Add error type for 409's
  2. Include response body text in error message content

@hinthornw hinthornw force-pushed the wfh/better_errors_ts branch from 05c993e to e3317ef Compare August 21, 2024 23:24
@hinthornw hinthornw force-pushed the wfh/better_errors_ts branch from da9ace4 to db7359b Compare August 21, 2024 23:52
@hinthornw hinthornw changed the title Add errors [JS] More Informative Errors Aug 21, 2024
@hinthornw hinthornw requested a review from jakerachleff August 21, 2024 23:54
@hinthornw hinthornw marked this pull request as ready for review August 22, 2024 00:06
@hinthornw hinthornw requested review from dqbd and jacoblee93 August 22, 2024 00:30
@jakerachleff
Copy link
Contributor

nice!! will let someone who knows js a bit better do signoff but this will be a huge improvement

jacoblee93
jacoblee93 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hinthornw hinthornw merged commit 4e8e454 into main Aug 22, 2024
11 checks passed
@hinthornw hinthornw deleted the wfh/better_errors_ts branch August 22, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

@dqbd dqbd dqbd approved these changes

@jakerachleff jakerachleff Awaiting requested review from jakerachleff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hinthornw @jakerachleff @dqbd @jacoblee93