python: add Client.similar_examples() and Client.index_dataset() #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
reviewed
Aug 15, 2024
hinthornw
reviewed
Aug 15, 2024
hinthornw
reviewed
Aug 15, 2024
baskaryan
commented
Aug 15, 2024
hinthornw
approved these changes
Aug 15, 2024
baskaryan
changed the title
baskaryan
changed the title
| ) | ||
| langchain_client.index_dataset(dataset_id=dataset.id) | ||
| # Need to wait for indexing to finish. | ||
| time.sleep(5) |
There was a problem hiding this comment.
we need to figure out a way to not make people need to do this...
There was a problem hiding this comment.
yea ideally you could poll it till its done. but also this is a one-time thing for any dataset so wonder if it's that high prio.
There was a problem hiding this comment.
Is there an indicator in the output to read_dataset we could use?
hinthornw
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods for interacting with
datasets/{dataset_id}/indexanddatasets/{dataset_id}/searchendpoints.Indexing takes a second so the integration test is skipped by default. Could turn it on or could update to use an existing index instead of creating one as part of the test.