feat(pairwise evals): add option to randomize order of experiments; print URL for pairwise experiment #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
reviewed
May 8, 2024
| @@ -586,6 +590,13 @@ def evaluate_comparative( | |||
| raise ValueError("max_concurrency must be a positive integer.") | |||
| client = client or langsmith.Client() | |||
|
|
|||
| if randomize_order: | |||
There was a problem hiding this comment.
I think I'd do this on a run level to average out bias within an experiment (as it stands, this will still have a consistent bias to 1 experiment, just random which one)
samnoyes
changed the title
hinthornw
approved these changes
May 8, 2024
| dataset_id = comparative_experiment.reference_dataset_id | ||
| base_url = project_url.split("/projects/p/")[0] | ||
| comparison_url = ( | ||
| f"{base_url}/datasets/{dataset_id}/compare?" |
There was a problem hiding this comment.
Nice - at some point may be nice to factor this uot
There was a problem hiding this comment.
Does this work if there's > 2 experiments? Is it more future proof if we just added a list of all the IDs?
There was a problem hiding this comment.
good point, will do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.