Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate uuids #282

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Validate uuids #282

merged 2 commits into from
Nov 3, 2023

Conversation

hinthornw
Copy link
Collaborator

@hinthornw hinthornw commented Nov 3, 2023 •
edited
Loading

In path

efriis
efriis reviewed Nov 3, 2023
View reviewed changes
python/langsmith/schemas.py
@@ -399,3 +399,6 @@ class DatasetShareSchema(TypedDict, total=False):
dataset_id: UUID
share_token: UUID
url: str


Example.update_forward_refs()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentional?

Copy link
Collaborator Author

@hinthornw hinthornw Nov 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I can separate to diff pr but was getting an issue with a kinda strange usage pattern

@hinthornw hinthornw merged commit 421eacf into main Nov 3, 2023
12 checks passed
@hinthornw hinthornw deleted the wfh/validate_uuids branch November 3, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hinthornw @efriis