RFC: httpx #237
Closed
RFC: httpx #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
commented
Sep 22, 2023
python/langsmith/client.py
Outdated
| filter_null_params: bool = True, | ||
| ) -> httpx.Response: | ||
| """Send a request with retries.""" | ||
| with _request_error_handler(request_method, url) as handler_state: |
There was a problem hiding this comment.
Thoughts on this error handling context manager to reduce duplicate handling code?
hinthornw
commented
Sep 22, 2023
python/langsmith/client.py
Outdated
| k: v for k, v in params.items() if v is not None | ||
| } | ||
| response = self._client.request(request_method, url, **request_kwargs) | ||
| handler_state["response"] = response |
There was a problem hiding this comment.
A bit weird way to add checking of response in the error handling...
hinthornw
force-pushed
the
wfh/acreate_feedback
branch
from
0bf8b01 to
5131f01
Compare
hinthornw
force-pushed
the
wfh/acreate_feedback
branch
from
5131f01 to
c0de1b1
Compare
hinthornw
force-pushed
the
wfh/acreate_feedback
branch
from
f5d1de7 to
bcb371c
Compare
hinthornw
force-pushed
the
wfh/acreate_feedback
branch
from
bcb371c to
c6eda2a
Compare
hinthornw
commented
Sep 28, 2023
| return | ||
| try: | ||
| with concurrent.futures.ThreadPoolExecutor(1) as executor: | ||
| executor.submit(lambda: asyncio.run(client.aclose())).result(timeout=10) |
There was a problem hiding this comment.
This may sometime lock if called explicitly in our tests if garbage collection isn't triggered explicitly beforehand (not always but sometimes). I'm not sure why at the moment.
hinthornw
force-pushed
the
wfh/acreate_feedback
branch
from
ba89c2b to
96bd67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love feedback on this. Especially on the following: